Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --force-systemd into cri-o #12553

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Implement --force-systemd into cri-o #12553

merged 2 commits into from
Sep 23, 2021

Conversation

spowelljr
Copy link
Member

Closes #12546

cri-o hasn't yet implemented the --force-systemd=true flag, added the feature.

Because cri-o defaults to systemd if no cgroup_manager set in /etc/crio/crio.conf, I've implemented that passing --force-systemd=true removes cgroup_manager from /etc/crio/crio.conf.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@kubernetes kubernetes deleted a comment from k8s-ci-robot Sep 22, 2021
@medyagh
Copy link
Member

medyagh commented Sep 22, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 22, 2021
@k8s-ci-robot
Copy link
Contributor

@spowelljr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-build 33e7a63 link true /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12553) |
+----------------+----------+---------------------+
| minikube start | 48.7s    | 48.5s               |
| enable ingress | 32.3s    | 33.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.1s 46.9s 48.0s 49.3s 47.2s
Times for minikube (PR 12553) start: 47.8s 49.1s 50.3s 48.6s 46.9s

Times for minikube ingress: 32.3s 32.8s 31.3s 32.3s 32.8s
Times for minikube (PR 12553) ingress: 33.3s 32.3s 32.5s 34.3s 32.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12553) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.5s               |
| enable ingress | 28.5s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.4s 30.0s 28.5s 26.9s 29.4s
Times for minikube (PR 12553) ingress: 34.5s 31.4s 28.9s 28.4s 35.9s

Times for minikube start: 22.2s 21.3s 21.9s 21.8s 21.7s
Times for minikube (PR 12553) start: 21.0s 22.5s 22.0s 20.9s 21.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12553) |
+----------------+----------+---------------------+
| minikube start | 35.8s    | 40.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.3s 43.7s 42.8s 24.9s 36.4s
Times for minikube (PR 12553) start: 30.4s 42.9s 43.0s 43.9s 44.2s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 7.69 (chart)
Docker_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 19.44 (chart)
Docker_Windows TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 28.99 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 30.83 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 35.00 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 49.28 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 60.29 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 61.67 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 64.17 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 65.00 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 67.50 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 77.50 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 90.83 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestAddons/parallel/Registry (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 8c0e46c into kubernetes:master Sep 23, 2021
@spowelljr spowelljr deleted the addForceSystemdCrio branch September 23, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement --force-systemd into cri-o
4 participants
@spowelljr @k8s-ci-robot @medyagh @minikube-pr-bot